Savestates: QoL improvements #12361
Merged
Savestates: QoL improvements #12361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
elad335
commented
Jul 17, 2022
•
elad335
commented
- Fix RAW SPU creation after loading the savestate.
- Fix Ctrl+R reload savestate shortcut bug.
- Fix bugs of vfs::retrieve.
- Do not restart after Ctrl+S for now.
- sys_mutex_unlock saving bugfix.
Megamouse
reviewed
Jul 17, 2022
| @@ -301,8 +301,8 @@ class Emulator final | |||
| bool Pause(bool freeze_emulation = false); | |||
| void Resume(); | |||
| void GracefulShutdown(bool allow_autoexit = true, bool async_op = false, bool savestate = false); | |||
| void Kill(bool allow_autoexit = true, bool savestate = false); | |||
| game_boot_result Restart(bool savestate = false); | |||
| std::shared_ptr<utils::serial> Kill(bool allow_autoexit = true, bool savestate = false); | |||
There was a problem hiding this comment.
There doesn't seem to be a reason to return a pointer here.
It's also really confusing as always
There was a problem hiding this comment.
This is for future functionality.
There was a problem hiding this comment.
The reason that m_ar is no longer used for it is because it can leak without management, here if it's unused it deallocates itself.
Nekotekina
reviewed
Jul 17, 2022
Utilities/File.cpp
Outdated
| std::string fs::resolve_path(std::string_view path) | ||
| { | ||
| std::error_code ec{}; | ||
| const auto result = std::filesystem::weakly_canonical(std::filesystem::u8path(path), ec); |
There was a problem hiding this comment.
Isn't this one of previously reverted things? Probably need to test it again if it's different now.
There was a problem hiding this comment.
The original pr bug has been fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.