Logs: Flush unreported errors when turning off Stack Cell errors #12366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Megamouse
reviewed
Jul 19, 2022
| @@ -2566,13 +2566,6 @@ s32 error_code::error_report(s32 result, const char* fmt, const fmt_type_info* s | |||
| if (!fmt) | |||
| { | |||
| // Report and clean error state | |||
|
|
|||
| if (g_log_all_errors) [[unlikely]] | |||
There was a problem hiding this comment.
This makes no sense.
You're now always stacking the errors in this case
There was a problem hiding this comment.
This block of code flushes unreported errors when the thread exits, it doesn't log new ones. https://github.com/RPCS3/rpcs3/blob/master/Utilities/Thread.cpp#L2061
There was a problem hiding this comment.
Well then it should still log all errors in this mode
There was a problem hiding this comment.
It's meaningless to spam the log in this code block. The information "lost" by stacking the errors is their time of occurrence which is still not recovered by repeatedly outputting the same message in a loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.