Fix Coverity and bump the version. #1238
Conversation
|
let version be 0.0.0.6 for now |
|
@DHrpcs3 Fixed. |
|
@DHrpcs3 may I wonder why? Atm rpcs3 versioning doesn't make much sense. Or more like doesn't carry any sense. It's far from semantic versioninc, there is no rules on when to bump it. We can get rid of it altogether (and use only github commits) without any consequences. |
|
@DHrpcs3 Why do you want at all costs to keep these three 0? Whether the LLVM, DX12, "interpreter 2" and all the rest, there's even already has several games that turns perfectly trading 60 fps, and the other works but gently (Disgaea 3) then why would a this kept many 0 when the emulator is already so advanced. The 0.0.0.6 is good, but it was eight months ago that he had put the it's just too late, the project out of position since, if one calculates a can, the emulator should 0.0.1 may be near the old tag were never as long term, the 5 remained more than a year, it's huge, + 2500 commit ... If I put 0.0.6 it was just simplified the thing, and also that the project had really enormous progress. |
|
@Zangetsu38, you say about performance. What about emulation? v0.0.0.4 execute more samples than current master branch version. Real different between v0.0.0.4 and v0.0.0.6 (or v0.0.6 or v0.0.1 or v542323.543.65563) not so much as you think |
|
@DHrpcs3 hmm I see. |
Fix Coverity and bump the version.
About the bump (from the commit message):
As it has been a long time since the last version bump, it would make sense to bump the version.
0.0.6 more specifically, since Zangetsu already did that and it was tagged and has already been linked on quite a few websites.It probably doesn't matter and 0.0.1 would make more sense.I would like @DHrpcs3 to confirm if this is OK and if the version bump is problematic, then I can remove that commit, so only the Coverity Scan fix remains.