Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented new config system. Minor improvements #1252

Merged
merged 5 commits into from Oct 13, 2015
Merged

Implemented new config system. Minor improvements #1252

merged 5 commits into from Oct 13, 2015

Conversation

DHrpcs3
Copy link
Contributor

@DHrpcs3 DHrpcs3 commented Oct 13, 2015

New config system allow make config files for specific game

DHrpcs3 added a commit that referenced this pull request Oct 13, 2015
Implemented new config system. Minor improvements
@DHrpcs3 DHrpcs3 merged commit d8d09b5 into RPCS3:master Oct 13, 2015
@danilaml
Copy link
Contributor

Why did you merge it without it even compiling on travis and appveyor? What's the point?

@DHrpcs3
Copy link
Contributor Author

DHrpcs3 commented Oct 13, 2015

Problem in travis clang configuration. Template depth limit must be increased to 512 or more (1024 must be enough)

@danilaml
Copy link
Contributor

@DHrpcs3 why not doing it in this PR before merging?

@DHrpcs3
Copy link
Contributor Author

DHrpcs3 commented Oct 13, 2015

@danilaml that can do anyone, I don't want spend time for travis configuration

@danilaml
Copy link
Contributor

@DHrpcs3 it's not travis config, but cmake one.
You'd just have to add -ftemplate-depth=1024 around here https://github.com/RPCS3/rpcs3/blob/master/rpcs3/CMakeLists.txt#L21

Anyway, I'll create the PR: #1253

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants