New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix GETLLAR spin detection and restore default configuration as before #12523 #12544
Conversation
bc987bc
to
b3407b9
Compare
ca537c2
to
ca653ae
Compare
454b908
to
b5bcc70
Compare
Relaxed default configuartions. |
Almost completely restores performance back to pre #12523 levels, well done. Testing with Persona 5 Previous master (14068) - 80 FPS As a side note, overall CPU usage has been reduced in this PR for all 3 permutations of settings compared to the previous master, from 66% to 62-64% on average, depending on Busy Waiting Percentage set. |
Seems to break performance in Ratchet and Clank Quest for Booty, according to Ramiro from the rpcs3 discord https://cdn.discordapp.com/attachments/272035812277878785/1011173235808796693/unknown.png https://discord.com/channels/272035812277878785/272035812277878785/1011173017692426262 |
Reset the settings! |
*renamed |
I tried the latest version of the optimization + fix and unfortunately I think that part of the performance increase has been lost .. the first versions were really smooth, in this build the improvement is less. however there is the bugfix. |
Please avoid commenting on the PR, it just causes confusion since other changes already happened since this PR. |
Revert GETLLAR polling detection to be off (100 by default now) and the setting has been renamed to "SPU GETLLAR Busy Waiting Percentage", added a new setting with the old one's name "SPU Reservation Busy Waiting Percentage" which controls busy-waiting in reading SPU_RdEventStat channel (0 by default). Demon Souls needs GETLLAR to be 0 to have the results of pr #12523.