SPU: fix atomicity of inaccurate GETLLAR #12730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tried with Motorstorm pacific, unfortunately it ends on infinite loading of game level as the master... |
|
If it's not a recent regression fixed by enabling accurate GETLLAR it's not related. |
maybe I misunderstood with spu accurate reservation, but is it just yakuza games? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea was that if we have pulled an atomic state of memory in the past we can declare new data as atomic as well if it matches its bytes without further checks. But this doesn't work if there was a GET or PUT command in between 2 GETLLARs with different data. This hopefully fixes some games needing "Accurate SPU GETLLAR" set to true that hadn't needed the setting before.