Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Full screen in DX12 #1282

Merged
merged 1 commit into from Nov 4, 2015
Merged

Fix Full screen in DX12 #1282

merged 1 commit into from Nov 4, 2015

Conversation

Zangetsu38
Copy link
Contributor

Fix window Full Screen With Double Left Click on DX12, same before, and same OpenGL.
PR Originel #1242

@Zangetsu38 Zangetsu38 mentioned this pull request Nov 3, 2015
@Zangetsu38
Copy link
Contributor Author

hmm Travis is Dead ?

@danilaml
Copy link
Contributor

danilaml commented Nov 3, 2015

Seems that it's just one time connection issue. It failed to download cmake.

@Nekotekina
Copy link
Member

Fine, but I think double-click must be removed to prevent conflicts with further (possible) mouse usage.
Alt+Enter is enough.

@Zangetsu38
Copy link
Contributor Author

@Nekotekina Yet I find it super convenient, and much better than the "Alt + Enter", which makes me a weird thing with me.
but I do not see how this could conflict, Windows Media Player, VLC etc, do it without problem ^^

@tambry
Copy link
Contributor

tambry commented Nov 4, 2015

@Zangetsu38 There's possibility of simulating the PlayStation Move controller using the mouse, which souns completely reasonable. As there are various buttons on the PlayStation Move controller, it would be nice/comfortable to for example click/dragging with click be responsible for the bottom button thingy and double click (and maybe dragging) to also simulate the top button.

I'm sorry if this explanation is a bit bad, since I don't exactly remember what those buttons are on the controller.

@Zangetsu38 Zangetsu38 deleted the d3d12-fix branch November 4, 2015 15:42
@danilaml
Copy link
Contributor

danilaml commented Nov 4, 2015

@tambry could be changed in the future. The better way to do this would be to provide fullscreen mode, but oGL render doesn't support it yet, afaik.

@Zangetsu38
Copy link
Contributor Author

@tambry hmm I see, in this case, it will just move does not emulate the mouse, but the move pointer, like Dolphin with the wiimote.

@tambry
Copy link
Contributor

tambry commented Nov 4, 2015

@Zangetsu38 I don't understand what you mean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants