-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cellGame: Add sleep when waiting for VSH #12853
Conversation
62ca14e
to
640ea2a
Compare
Uh, wait, there's another bug. |
Hi, can this PR be updated again? I would like to test if this could reach ingame, or gets stuck during menus. |
I'm not really sure why the build failed. |
Raised sleep time of the game size calculating functions, they are obviously very slow in nature due to the fact that it calculates the size of entire game directories with PS3 HDD. This makes the game boot flawlessly on my end. |
b10163e
to
9770198
Compare
rpcs3.zip |
Uhh, it seems to be loading infinitely. |
Delete created game data. |
Sorry if this sounds stupid, but how do I delete created game data? |
Does it boot? upload log if not. |
Still infinitely loads. |
rpcs3.zip |
Nothing changes, even if I deleted the PS3 game data. |
I think I will merge the pr anyways for now. |
Those functions are supposed to take a really long time, and in this time the caller PPU waits for VSH.
To be honest if it's not possible to fix this issue at this current state, that is totally fine to me. |
The first commit fixes the infinite loading with Transformers: Rise of the Dark Spark. This was a proven fix on real hw for a long time that I forgot after a while, turned out this fixes this game.This commit was actually merged as part of the GT5 fixes.
This game is very sensitive to PPU scheduler changes, the access violation returns when changing PPU thread count to +3.
I haven't even tried to get ingame though, maybe testers can check its new status later.
Fixes booting of Transformers: Rise of the Dark Spark for some people, this may need more time adjustments to work for all people.