Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cellGame: Add sleep when waiting for VSH #12853

Merged
merged 2 commits into from
Aug 7, 2023
Merged

Conversation

elad335
Copy link
Contributor

@elad335 elad335 commented Oct 21, 2022

  • The first commit fixes the infinite loading with Transformers: Rise of the Dark Spark. This was a proven fix on real hw for a long time that I forgot after a while, turned out this fixes this game.
    This commit was actually merged as part of the GT5 fixes.
  • Interestingly, after the first attempt when it got to menu, the savedata it created caused a fatal access violation on the next boot until I removed savedata. After some investigation, it turned out adding a single lv2_obj::sleep to cellGameDataCheck fixed it even without time sleeping, but I've added more with timed sleep to it and more cellGame functions to better match real PS3 as those functions take a really long PPU time to process on real hw. (time in which the caller PPU is asleep waiting for VSH)
    This game is very sensitive to PPU scheduler changes, the access violation returns when changing PPU thread count to +3.

I haven't even tried to get ingame though, maybe testers can check its new status later.
Fixes booting of Transformers: Rise of the Dark Spark for some people, this may need more time adjustments to work for all people.

@elad335 elad335 force-pushed the trans branch 2 times, most recently from 62ca14e to 640ea2a Compare October 21, 2022 10:01
@elad335 elad335 marked this pull request as draft October 21, 2022 10:19
@elad335
Copy link
Contributor Author

elad335 commented Oct 21, 2022

Uh, wait, there's another bug.

@Ordinary205
Copy link
Contributor

Hi, can this PR be updated again? I would like to test if this could reach ingame, or gets stuck during menus.

@Ordinary205
Copy link
Contributor

I'm not really sure why the build failed.

@elad335 elad335 marked this pull request as ready for review August 2, 2023 16:14
@elad335
Copy link
Contributor Author

elad335 commented Aug 2, 2023

Raised sleep time of the game size calculating functions, they are obviously very slow in nature due to the fact that it calculates the size of entire game directories with PS3 HDD. This makes the game boot flawlessly on my end.

@elad335 elad335 force-pushed the trans branch 2 times, most recently from b10163e to 9770198 Compare August 2, 2023 16:20
@elad335 elad335 changed the title LV2/cellGame: Pair of fixes cellGame: Add sleep when waiting for VSH Aug 2, 2023
@elad335
Copy link
Contributor Author

elad335 commented Aug 2, 2023

rpcs3.zip
rpcs3.exe cause CI failed.

@Ordinary205
Copy link
Contributor

Uhh, it seems to be loading infinitely.
Transformers rise of the dark spark
RPCS3.log.gz

@elad335
Copy link
Contributor Author

elad335 commented Aug 2, 2023

Delete created game data.

@elad335
Copy link
Contributor Author

elad335 commented Aug 2, 2023

image

The pr description also says to delete previous savedata.

@Ordinary205
Copy link
Contributor

Sorry if this sounds stupid, but how do I delete created game data?

@elad335
Copy link
Contributor Author

elad335 commented Aug 2, 2023

image
Then "PS3 Game data" category appears and delete from game list, also delete savedata using the save manager.

@Ordinary205
Copy link
Contributor

I deleted the PS3 game data, but I am unable to find it on save manager.
No savedata

@elad335
Copy link
Contributor Author

elad335 commented Aug 2, 2023

Does it boot? upload log if not.

@Ordinary205
Copy link
Contributor

Still infinitely loads.
RPCS3.log.gz

@elad335
Copy link
Contributor Author

elad335 commented Aug 2, 2023

rpcs3.zip
Retest.

@Ordinary205
Copy link
Contributor

Nothing changes, even if I deleted the PS3 game data.
RPCS3.log.gz

@elad335
Copy link
Contributor Author

elad335 commented Aug 7, 2023

I think I will merge the pr anyways for now.

Those functions are supposed to take a really long time, and in this time the caller PPU waits for VSH.
@Ordinary205
Copy link
Contributor

Ordinary205 commented Aug 7, 2023

To be honest if it's not possible to fix this issue at this current state, that is totally fine to me.

@elad335 elad335 merged commit 0989f62 into RPCS3:master Aug 7, 2023
5 checks passed
@elad335 elad335 deleted the trans branch May 6, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants