VSH: implement sys_fs_mount() and sys_fs_unmount()

[brian218]

Implemented sys_fs_mount() and sys_fs_unmount() for VSH.
Solve:

SYS: 'sys_fs_stat' failed with 0x8001003a : CELL_ENOTMOUNTED, “/dev_hdd1/crash_report/kernel/ps3crash-kernel.dat.tmp”
SYS: 'sys_fs_disk_free' failed with 0x80010002 : CELL_EINVAL, “/dev_hdd1”
SYS: 'sys_fs_open' failed with 0x8001003a : CELL_ENOTMOUNTED, “/dev_hdd1”
SYS: 'sys_fs_unlink' failed with 0x8001003a : CELL_ENOTMOUNTED, “/dev_hdd1/PS3UPDATE/ps3version.txt”
SYS: 'sys_fs_rmdir' failed with 0x8001003a : CELL_ENOTMOUNTED, “/dev_hdd1/PS3UPDATE”

Also corrected some existing typos of dev_flash things in System.cpp by the way.

[elad335]

Is there actual proof of it being mounted at boot with VSH? maybe it calls a syscall to mount manually?

[brian218]

Is there actual proof of it being mounted at boot with VSH? maybe it calls a syscall to mount manually?

Yes, from the log I can see the VSH attempted to mount dev_hdd1 in the same way as dev_hdd0 (by sys_fs_mount()):

sys_fs TODO: sys_fs_mount(dev_name=“CELL_FS_IOS:PATA1_HDD_DRIVE”, file_system=“CELL_FS_UFS”, path=“/dev_hdd0”, unk1=0x0, prot=0x0, unk3=0x0, str1=“”, str_len=0)
sys_fs TODO: sys_fs_mount(dev_name=“CELL_FS_IOS:PATA1_HDD_DRIVE”, file_system=“CELL_FS_FAT”, path=“/dev_hdd1”, unk1=0x0, prot=0x0, unk3=0x0, str1=“”, str_len=0)

But I don't think dev_hdd1 was even going to be mounted in RPCS3, since sys_fs_mount() does nothing other than just logging a todo, and dev_hdd1 would never be mounted by System.cpp (see line 281 in this PR; the value of the variable "hdd1" was never actually set somewhere else).

[elad335]

Well, you can implement without checking of anything other than path.

[brian218]

Well, you can implement without checking of anything other than path.

Sorry, but I didn't get your point.

[elad335]

You can hook the syscall when it tries to mount hdd1 to vfs::mount, I suggest creating a directory in dev_hdd1/caches/ that will be unique to VSH and cleared every mount.

[elad335]

Probably even without caring about mounting of other mount points for now.

[elad335]

The code needed in the syscall is not so different from what you just wrote. It's a bad idea hacking it in Emulator::Init.

[brian218]

Both sys_fs_mount() and sys_fs_unmount() are implemented now.

[elad335]

I suggest creating a directory in /dev_hdd1/caches/ that will be unique to VSH and cleared every mount.

I forgot, this is very important otherwise VSH would access HDD1 images of games and can erase or modify them.

[elad335]

You see, rpcs3/dev_hdd1/ is not actually the PS3 directory but a parent of co-existing instances of it for different games or applications. The reasoning behind it is that intact HDD1 state results in better performance but its state is not compatible with different games. real PS3 simply clears it when switching application.

[brian218]

I suggest creating a directory in /dev_hdd1/caches/ that will be unique to VSH and cleared every mount.

I forgot, this is very important otherwise VSH would access HDD1 images of games and can erase or modify them.

You mean it should mount /dev_hdd1/caches/ instead?

[brian218]

You see, rpcs3/dev_hdd1/ is not actually the PS3 directory but a parent of co-existing instances of it for different games or applications. The reasoning behind it is that intact HDD1 state results in better performance but its state is not compatible with different games. real PS3 simply clears it when switching application.

I wonder why RPCS3 doesn't do the same thing as the real PS3 does (clear dev_hdd1).

[elad335]

Mount /dev_hdd1/caches/vsh.

[brian218]

Mount /dev_hdd1/caches/vsh.

Done.