New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cellGcm: add more enums #13587
cellGcm: add more enums #13587
Conversation
Unused code is bloat. We should only include what we need. |
It has documentary purposes though. |
怎么下载 |
Except its unused, so there's no context. It's like a large comment. Makes more sense to put in a wiki or docs repo (which we don't have) to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤷♂️
Did you really review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something or other.
The review was more of "I don't know where this is going, I wouldn't allow it, but people seem to want it in and it's a democracy" |
37bb307
to
659fae2
Compare
No description provided.