Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cellGcm: add more enums #13587

Merged
merged 2 commits into from Apr 7, 2023
Merged

cellGcm: add more enums #13587

merged 2 commits into from Apr 7, 2023

Conversation

Megamouse
Copy link
Contributor

No description provided.

@kd-11
Copy link
Contributor

kd-11 commented Mar 29, 2023

Unused code is bloat. We should only include what we need.

@elad335
Copy link
Contributor

elad335 commented Mar 30, 2023

It has documentary purposes though.

@18112238990
Copy link

怎么下载

@kd-11
Copy link
Contributor

kd-11 commented Apr 4, 2023

It has documentary purposes though.

Except its unused, so there's no context. It's like a large comment. Makes more sense to put in a wiki or docs repo (which we don't have) to me.
There's a ton of undocumented stuff that we don't include in the code repo because it is not relevant for emulation.

Copy link
Contributor

@kd-11 kd-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷‍♂️

@Megamouse
Copy link
Contributor Author

Did you really review?
I left in two weird places clearly meant for the reviewer xD

rpcs3/Emu/RSX/gcm_enums.h Outdated Show resolved Hide resolved
rpcs3/Emu/RSX/gcm_enums.h Outdated Show resolved Hide resolved
Copy link
Contributor

@kd-11 kd-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something or other.

@kd-11
Copy link
Contributor

kd-11 commented Apr 4, 2023

Did you really review? I left in two weird places clearly meant for the reviewer xD

The review was more of "I don't know where this is going, I wouldn't allow it, but people seem to want it in and it's a democracy"
For the questions, ask in GH comments, my brain subconsciously ignores code comments XD

@Megamouse Megamouse merged commit 60fc51e into RPCS3:master Apr 7, 2023
4 of 5 checks passed
@Megamouse Megamouse deleted the audio2 branch April 7, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants