Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invert the DJ Hero Turntable crossfader axis bind. #13636

Merged
merged 2 commits into from Apr 16, 2023

Conversation

shockdude
Copy link
Contributor

Back when I submitted turntable emulation in #9965, I set the crossfader bind such that Crossfade Left was Y Up and Crossfade Right was Y Down, intending to imitate the binds of an Xbox 360 turntable.

Turns out I messed up. On Xbox 360 turntables, Crossfade Left is Y Down, Crossfade Right is Y Up.
This PR flips the crossfader bind to match the real turntable's inputs.

This will flip the crossfader for all emulated turntable users until they rebind, but I'm familiar with the DJ Hero community and I think it's worth a one-time change for accuracy.

Also fix turntable/left stick input overflow while I'm here.

@shockdude
Copy link
Contributor Author

shockdude commented Apr 9, 2023

This change also makes setting up Wii turntables using the WiitarThing driver much easier, as WiitarThing emulates a 360 controller and already outputs the correct axes for the turntable crossfader (using WiitarThing with current RPCS3 results in an inverted crossfader ingame)

@shockdude
Copy link
Contributor Author

Is there anything else I need to do for this PR?

@Megamouse
Copy link
Contributor

I mean i could merge it, but wouldn't it make more sense to understand the underlying issue with mmjoy vs xinput first?

On Xbox 360 turntables, Crossfade Left is Y Down, Crossfade Right is Y Up.
Also simplify turntable/left stick input.
@shockdude
Copy link
Contributor Author

shockdude commented Apr 15, 2023

I mean i could merge it, but wouldn't it make more sense to understand the underlying issue with mmjoy vs xinput first?

I found the underlying issue, see #13671. Simplified this PR based on #13671 getting merged.

The check for buf[6] == 127 is still required in the case of joysticks centered at (128,128), but at least there's no funny behavior (subtracting from 256 instead of 255) due to joysticks centered at (126,126).

@Megamouse Megamouse merged commit b706658 into RPCS3:master Apr 16, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants