Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPU LLVM: experimental change #13710

Merged
merged 1 commit into from Apr 21, 2023
Merged

SPU LLVM: experimental change #13710

merged 1 commit into from Apr 21, 2023

Conversation

Nekotekina
Copy link
Member

Please test.

@Ordinary205
Copy link
Contributor

Ordinary205 commented Apr 20, 2023

RPCS3 crashes when building a SPU cache on this PR Build.
RPCS3.log.gz

@Nekotekina
Copy link
Member Author

Can I get more results from different games?

@Ordinary205
Copy link
Contributor

Ordinary205 commented Apr 20, 2023

It crashes on every games that I've tested, including Demon's Souls.

Edit: Oh wait, it doesn't crash on the game called "The Wolf Among Us"
RPCS3.log.gz

@Darkhost1999
Copy link
Contributor

Darkhost1999 commented Apr 20, 2023

Assassin's Creed [NPUB30451].log
Works really well with first time building a cache but closes RPCS3 when loading an existing cache.

@Ordinary205
Copy link
Contributor

So basically the results are:

Midnight Club: LA
Crashes
RPCS3.log.gz

Demon's Souls
Crashes
RPCS3.log.gz

The Wolf Among Us
Doesn't crash
RPCS3.log.gz

God of War III
Crashes
RPCS3.log.gz

God of War: Asension
Crashes
RPCS3.log.gz

Need for Speed: The Run
Crashes
RPCS3.log.gz

Battlefield 3
Crashes
RPCS3.log.gz

InFamous
Doesnt crash
RPCS3.log.gz

Red Dead Redemption
Crashes
RPCS3.log.gz

@Nekotekina
Copy link
Member Author

I see, please retest

@Ordinary205
Copy link
Contributor

Sorry if this is a dumb question, but are you creating this PR just to improve the stability or the performance?

@Darkhost1999
Copy link
Contributor

RPCS3.log.gz
I'm not noticing any issues now

@Nekotekina
Copy link
Member Author

@Ordinary205 basically performance

@Darkhost1999

This comment was marked as outdated.

@Darkhost1999
Copy link
Contributor

This change positively effects Netflix's first boot with a brand new SPU cache. Bringing the ability to get to the login to your profile screen considerably faster than ever before. 😁

@Yahfz
Copy link
Contributor

Yahfz commented Apr 20, 2023

Master SPU Test v1.1.2 by GalCiv SPU Task Avalanche completed in 5269 ms (PS3: 2740 ms) PPU/SPU Ping-Pong completed in 3441 ms (PS3: 3045 ms) SPU MFC 64 Bits War completed in 15490 ms (PS3: 3370 ms) PPU/SPU MFC 64 Bits War completed in 17235 ms (PS3: 4443 ms) SPU Integer Perf completed in 17155 ms (PS3: 8666 ms) SPU Float Perf completed in 5841 ms (PS3: 2379 ms) SPU SpinLock completed in 9038 ms (PS3: 4409 ms) PUTLLUC Perf completed in 7240 ms (PS3: 3853 ms) PUTLLC Perf completed in 9469 ms (PS3: 3364 ms) PUT Perf completed in 5986 ms (PS3: 3984 ms) Large PUT Perf completed in 11345 ms (PS3: 4454 ms) --Completed 11 tests in 107518 ms--

64Bd70c SPU Test v1.1.2 by GalCiv SPU Task Avalanche completed in 5445 ms (PS3: 2740 ms) PPU/SPU Ping-Pong completed in 3374 ms (PS3: 3045 ms) SPU MFC 64 Bits War completed in 15442 ms (PS3: 3370 ms) PPU/SPU MFC 64 Bits War completed in 18003 ms (PS3: 4443 ms) SPU Integer Perf completed in 2493 ms (PS3: 8666 ms) SPU Float Perf completed in 720 ms (PS3: 2379 ms) SPU SpinLock completed in 8985 ms (PS3: 4409 ms) PUTLLUC Perf completed in 6596 ms (PS3: 3853 ms) PUTLLC Perf completed in 6995 ms (PS3: 3364 ms) PUT Perf completed in 4320 ms (PS3: 3984 ms) Large PUT Perf completed in 11586 ms (PS3: 4454 ms) --Completed 11 tests in 83967 ms--

SPU Integer Perf, SPU Float Perf & PUT Perf look better to me

I mean, if this PR improved your float performance this much over master then we can pack it up cause RPCS3 is done. That much of an increase is almost like going from a core 2 duo to a ryzen 3700X, those results aren't correct.

@Darkhost1999
Copy link
Contributor

Darkhost1999 commented Apr 20, 2023

I copied and pasted. But I'll run the test a couple of times on master more than just 1st boot and replace the master test results

@Darkhost1999
Copy link
Contributor

Numbers are much closer together but still overall improvement unless the numbers are supposed to keep going down every time you run the test

Master
TTY.log
64bd70c
TTY.log

@Nekotekina
Copy link
Member Author

I think it's just a LLVM16 PR regression that is fixed.

@solarmystic
Copy link

Back again with the usual 5 game (P5, DeS, TLOU, GOWA, GOW3) round up.

All 5 games booted and ran fine. Performance is within margin of error for all games tested compared to master so I felt that individual break downs were unnecessary.

Captured SS with results for those who're interested:-
891 vs SPU Exp.zip

@Ordinary205
Copy link
Contributor

Ordinary205 commented Apr 21, 2023

@solarmystic does that count as a performance regression when god of war III has lower 1% FPS than master?
Because I'm pretty sure it does.

@solarmystic
Copy link

solarmystic commented Apr 21, 2023

Retested again with latest pr commit (9e75cb9) versus latest master (14896).

GOW 3 - Minor gain on average FPS, minor reduction in 1% FPS.
Master - 128/95/69 FPS
This PR (9e75cb9) - 130/91/69 FPS

GOWA - Within margin of error for average FPS, minor gain in 1% and 0.1% FPS.
Master - 65/58/53 FPS
This PR (9e75cb9) - 66/61/56 FPS

The Last of Us - Identical average FPS, minor gain in 0.1% FPS
Master - 51/46/42 FPS
This PR (9e75cb9) - 51/47/45 FPS

Persona 5 - Within margin of error for all metrics.
Master - 89/64/57 FPS
This PR (9e75cb9) - 89/62/57 FPS

Demon's Souls - Within margin of error on average, slight reduction in 1% FPS.
Master - 105/89/82 FPS
This PR (9e75cb9) - 106/87/82 FPS

SS with all results:-
896 vs SPU Exp 2.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants