Qt: fix invisible first icon in game list #13796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once the first icon got smaller than 30 pixels it wasn't counted as visible.
It turns out that the visibleRegion of the table has an offset that is exactly the size of the table headers.
So the visibleRegion started at (0,30), while the icons' visualRects started at the origin of the table itself (without headers).
When a small icon was at (0,0) with a height below 30 it would therefore never pass the visibility checks.
Simply offsetting the visibleRegion by the header size brought its position back to (0,0), meaning we can properly do the check.