Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPU/PPU/Debugger: Ensure ascending stack frames #13833

Merged
merged 4 commits into from May 10, 2023
Merged

SPU/PPU/Debugger: Ensure ascending stack frames #13833

merged 4 commits into from May 10, 2023
+22 −2

Conversation

elad335
Copy link
Contributor

@elad335 elad335 commented May 9, 2023 •
edited

  • Prevents infinite loop and finally crashing RPCS3 on memory exhaustion in case one stack frame value matches any of the previous ones.
  • This also prevents simple generic errors as well like descending stack frames when tracing backwards which is not ABI complaint as well.

@Nekotekina Nekotekina merged commit db7f84f into RPCS3:master May 10, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Megamouse Megamouse Megamouse left review comments

Assignees
No one assigned
Labels
Debugger
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@elad335 @Megamouse @Nekotekina