-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cellSpurs: Implement ShutdownTaskset and WorkloadFlagReceiver2 #13916
Conversation
rpcs3/Emu/Cell/Modules/cellSpurs.cpp
Outdated
{ | ||
UNIMPLEMENTED_FUNC(cellSpurs); | ||
return CELL_OK; | ||
cellSpurs.warning("_cellSpursWorkloadFlagReceiver2(spurs=*0x%x, wid=%d, is_set=%d, print_debug_output=0%d)", spurs, wid, is_set, print_debug_output); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why 0%d with zero prefix?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
if (is_set) | ||
{ | ||
if (FlagReceiver == 0xff) | ||
{ | ||
FlagReceiver = static_cast<u8>(wid); | ||
} | ||
} | ||
else | ||
{ | ||
if (FlagReceiver == wid) | ||
{ | ||
FlagReceiver = 0xff; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seems redundant.
can't you just set FlagReceiver in the scopes above ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just seen it and they way it is is much more readable.
No description provided.