Skip to content

Memory Viewer Improvements #14051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 21, 2023
Merged

Memory Viewer Improvements #14051

merged 7 commits into from
Jun 21, 2023

Conversation

knight4u32
Copy link
Contributor

@knight4u32 knight4u32 commented Jun 19, 2023 •
edited
Loading

  • Add auto-refresh mode for the memory viewer, refreshing contents in 60hz.
  • Shortcut in RSX debugger to view RSX semaphores area. (Alt+S)
  • Add Grey8 and a special G32MAX (shows the max color between sets of neighboring 4-byte groups) image formats.
  • Fix memory leak in the memory viewer.
  • Add Ctrl+PageDown, Ctrl+PageUp shortucts for faster scrolling.
  • Add Ctrl+F to refocus on the address line.
  • Add Ctrl+F5 for manual, single memory refresh.
  • Added image scaling for image viewer with Ctrl+Plus, Ctrl+Minus.
  • Added hover position for image viewer to see which address is being pointed at, when double clicking on it the image viewer is closed and the memory viewer jumps to the clicked memory data.

@knight4u32 knight4u32 force-pushed the memory-viewer branch 6 times, most recently from 48389a8 to 0a2a083 Compare June 19, 2023 20:10
@knight4u32 knight4u32 changed the title Add Refresh mode for memory viewer Memory Viewer Imporements Jun 20, 2023
@knight4u32
Copy link
Contributor Author

  • Added image scaling with Ctrl+Plus, Ctrl+Minus.
  • Added hover position to see which address is being pointed at, when double clicking on it the image viewer is closed and the memory viewer jumps to the clicked memory data.
    image

@knight4u32 knight4u32 changed the title Memory Viewer Imporements Memory Viewer Improvements Jun 21, 2023
@knight4u32 knight4u32 force-pushed the memory-viewer branch 5 times, most recently from 503cb04 to f0e9853 Compare June 21, 2023 08:17
@knight4u32 knight4u32 force-pushed the memory-viewer branch 4 times, most recently from 4fef1d2 to 2e1c947 Compare June 21, 2023 09:19
@knight4u32
Utilities/Memory Viewer: Improve image viewer
26c7c4c 
* Added image scaling with Ctrl+Plus, Ctrl+Minus.
* Added hover position to see which address is being pointed at, when double clicking on it the image viewer is closed and the memory viewer jumps to the clicked memory data.
@kd-11 kd-11 merged commit 00cca7b into RPCS3:master Jun 21, 2023
Megamouse
Megamouse reviewed Jun 21, 2023
View reviewed changes
rpcs3/rpcs3qt/memory_viewer_panel.cpp
});

break;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing default

@knight4u32 knight4u32 deleted the memory-viewer branch June 22, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Megamouse Megamouse Megamouse left review comments

@kd-11 kd-11 kd-11 approved these changes

Assignees
No one assigned
Labels
Debugger GUI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@knight4u32 @kd-11 @Megamouse