Qt: Save UI settings and geometry safely on closeEvent #14060
Conversation
elad335
commented
Jun 20, 2023
•
elad335
commented
- Parameters may have changed before the destructor of Qt objects have been called, save UI geometry and settings in closeEvent instead.
- Save to disk once the dialog or main window is closed so force application termination or powerloss won't cause the settings to be lost. (but not too frequantly because it can spam the disk)
elad335
force-pushed
the
save-safe
branch
3 times, most recently
from
552583c
to
3f91a95
Compare
|
This is all unrelated |
|
Sorry, wrong button |
elad335
changed the title
elad335
force-pushed
the
save-safe
branch
2 times, most recently
from
1e8ee9f
to
e10a293
Compare
|
Fixed properly now. |
|
The whole sorting makes no sense unless you already scrolled through the entire list. Also, 50% of these changes seem entirely random and unrelated to the issue. |
elad335
force-pushed
the
save-safe
branch
2 times, most recently
from
4dad3bd
to
e82cde1
Compare
elad335
changed the title
|
Changed the purpose of the pr. |
|
I don't understand why this is necessary. |
|
I think @Darkhost1999 posted it fixed the geomtery saving for his setup on discord. |
rpcs3/rpcs3qt/game_list_frame.cpp
Outdated
| WaitAndAbortSizeCalcThreads(); | ||
| WaitAndAbortRepaintThreads(); | ||
| gui::utils::stop_future_watcher(m_parsing_watcher, true); | ||
| gui::utils::stop_future_watcher(m_refresh_watcher, true); | ||
|
|
||
| SaveSettings(); | ||
|
|
There was a problem hiding this comment.
There seems to be a fundamental misunderstanding of the QDockWidget::closeEvent...
This event is only triggered if you manually click the X in the dock.
So this change is wrong.
There was a problem hiding this comment.
main_windoww::closeEvent also calls m_game_list_frame->SaveSettings().
There was a problem hiding this comment.
main_windoww::closeEvent also calls m_game_list_frame->SaveSettings().
Well. now it probably isn't saved when you actually use the closeEvent.
I don't understand the constant need to change everything seemingly just out of boredom
elad335
force-pushed
the
save-safe
branch
2 times, most recently
from
7bb2284
to
3fa2288
Compare
