Fix Create PPU Cache, Implement SELF precompilation, Savestate fix 1 out of 3

[elad335]

• Fix Create PPU Cache, allow it to be usable again.
• Implement PPU SELF precompilation, preventing compilation ingame with many game collections, RDR, GT6 and more.
• Make bad game patches not able to crash the emulator, simply ignore them (bad addresses resulted in segfaults)
• Add one fix of savestate.

Fixes #12320
Fixes #14080

[Darkhost1999]

Creating Cache.log
Booting Game.log
While #14080 is resolved by this PR. 🏆

And #14024 resolved by #14034
There are still issues with the create PPU cache option

Netflix [NPUP00030].log
The 2 sprx and the .self fail to decrypt

Call of Duty Ghosts [BLUS31270].log and many more
The Eboot compiles whilst the other .self files say (prx: Invalid ELF type, ovl: Invalid ELF type)

Meanwhile this is the more I was excited about in the other PR. Yes that is 1.10 compiling

The other was seeing AC Revelations (Update) compiling when they hadn't before.

TLDR: This issue solves the goal it was intended to solve. The Function isn't perfect.
And I now tested booting the games after creating cache not just creating the cache.

[Darkhost1999]

The remaining "issues" with the create PPU cache option I believe are and have just been unimplemented and not result of a PR

[elad335]

@Darkhost1999 Retest with latest build.

[Darkhost1999]

·F 0:19:35.849168 SIG: Thread terminated due to fatal error: Verification failed
(in file C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\rpcs3\Emu\System.cpp:1396[:6], in function Load) (error=0x2)
RPCS3.log
You're still pushing changes and so idk if this is useful anymore. lmk when you're ready.

[elad335]

Retry with latest when it builds.
Also it would be nice if someone can benchmark MGS4 precompilation and firmware compilation speeds before and after.
Even with the cache in place (should be faster even to just link modules).

[solarmystic]

Retry with latest when it builds. Also it would be nice if someone can benchmark MGS4 precompilation and firmware compilation speeds before and after. Even with the cache in place (should be faster even to just link modules).

@elad335 Using the latest test build, with existing PPU cache in place from latest master, MGS4 crashes and takes down rpcs3 after pressing X on this screen.

Crashlog:-
RPCS3.log

[elad335]

Retest.

[Ordinary205]

I decided to test it on Watch Dogs, and start the timer for how long it takes to compile/link PPU modules.

Master (15240 Build):
1 minute 31 seconds

PR:
2 minutes 35 seconds

RPCS3.log.gz
RPCS3.log.gz

[Ordinary205]

Here's the second results:

Master (15240 Build):
1 minute 31 seconds

PR (14cfcee Build):
1 minute 31 seconds

PR log:
RPCS3.log.gz

No differences of what I can see.

[Ordinary205]

The newest commit seems to have minor performance regression during the PPU compilation.

Before (14cfcee Build):
1 minute 31 seconds

After (6ac2dce Build):
1 minute 36 seconds

RPCS3.log.gz

[ItsLaguna]

MGS4 updated to v2.00 still compiles in loading screens despite being precompiled (I'll try to keep up with the commits, but this game takes over an hour)

PPU Cache precomp 14cfcee3.log
run after precompile 14cfcee3.log

[elad335]

Ah because MGS4.SELF is encrypted with special key, rip then, those keys need to be obtained when the game is running in runtime.

[ItsLaguna]

Ah because MGS4.SELF is encrypted with special key, rip then, those keys need to be obtained when the game is running in runtime.

Well, that is unfortunate 😢

[MisterbALLIN]

This update broke RDR GOTY (BLES01294).

With the previous version #14090, Red Dead works well and boots up correctly, but this PR can't boot the game up and crashes the whole emulator when the game finishs precompilation.