Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rsx: Clamp MSAA sampling weights to avoid clipping #14131

Merged
merged 3 commits into from Jul 4, 2023

Conversation

kd-11
Copy link
Contributor

@kd-11 kd-11 commented Jul 4, 2023

Fixes #12514

@kd-11 kd-11 changed the title Clamp MSAA sampling weights to avoid clipping rsx: Clamp MSAA sampling weights to avoid clipping Jul 4, 2023
@Linear524
Copy link

Great job KD-11 !
Sorry for the offtop, but can this PR fix #8442 ? There is still error with E RSX: Transfer cropped in Y, src_h=810, offset_y=1, block_h=810
Or that issue is unrelated to MSAA function ?

@kd-11
Copy link
Contributor Author

kd-11 commented Jul 4, 2023

Great job KD-11 ! Sorry for the offtop, but can this PR fix #8442 ? There is still error with E RSX: Transfer cropped in Y, src_h=810, offset_y=1, block_h=810 Or that issue is unrelated to MSAA function ?

That is unrelated. It's also more of a warning about missing pixels than an error that can cause crashes.

@kd-11 kd-11 merged commit d41fe80 into RPCS3:master Jul 4, 2023
4 of 5 checks passed
@kd-11 kd-11 deleted the msaa-weights-clamp branch July 4, 2023 23:51
@Linear524
Copy link

TLoU and GT6 is still broken with by this PR:
Projection shadows or shadowmaps are screwed in TLoU.
GT6 have some weird green dots in lower right corner.

@Linear524
Copy link

2358
2359
2360
2361
2362
2363

@Linear524
Copy link

Forgot to write my HW specs:

  • SYS: RPCS3 v0.0.28-15306-d41fe80b Alpha | master
  • SYS: Intel(R) Xeon(R) CPU E5-2690 v4 @ 2.60GHz | 14 Threads | 31.83 GiB RAM | TSC: 2.594GHz | AVX+ | FMA3 | TSX disabled by default
  • SYS: Operating system: Windows, Major: 10, Minor: 0, Build: 18362, Service Pack: none, Compatibility mode: 0
  • SYS: Current Time: 2023-07- 5T23:24:13
  • RSX: Found vulkan-compatible GPU: 'NVIDIA GeForce GTX 1080' running on driver 531.61.0.0
  • SYS: Firmware version: 4.87

@kd-11
Copy link
Contributor Author

kd-11 commented Jul 5, 2023

Open a bug report. The PR has already been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A
2 participants