Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt/Patches: Improve patch validation and patch creator #14172

Merged
merged 7 commits into from Jul 13, 2023

Conversation

Megamouse
Copy link
Contributor

@Megamouse Megamouse commented Jul 9, 2023

Backend:

  • Validate yml patch offset values (prevent overflow)
  • Do not allow empty patch names
  • Fix logging for locations of node iterators (previously "location: invalid node")
  • Improve location logging of some other invalid patch nodes

Frontend:

  • Add validator to patch creator bottom offset line edit (updates depending on patch type)
  • Add clear buttons to patch creator bottom line edits
  • Highlight faulty lines in patch creator
  • Fix some memory leaks regarding QValidators

Caveats:

  • The table itself doesn't validate the offset input, but at least you now get better feedback in general.

fixes #14169

@Megamouse Megamouse added the GUI label Jul 9, 2023
@elad335
Copy link
Contributor

elad335 commented Jul 10, 2023

File path as of recently can also be typed in offset, this should reflect that.

@Megamouse Megamouse marked this pull request as draft July 10, 2023 22:33
@Megamouse Megamouse marked this pull request as ready for review July 11, 2023 23:24
@Megamouse Megamouse changed the title Qt: add validator to patch creator offset lineedit Qt/Patches: Improve patch validation and patch creator Jul 11, 2023
@Megamouse Megamouse added the Patches Patches and Mods label Jul 12, 2023
@Megamouse Megamouse merged commit a828c21 into RPCS3:master Jul 13, 2023
5 checks passed
@Megamouse Megamouse deleted the fixes branch July 13, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI Patches Patches and Mods
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GUI: Patch creator should prevent the addition of offsets bigger than 8 bytes
2 participants