PPU/Debugger: View the currently used CR field content in register panel #14188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elad335
force-pushed
the
debug-cr
branch
8 times, most recently
from
4c920c7
to
38810e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CR register is composed of 8 different fields which are 32 bits in total, it's not easy to track and intuitively understand its relavant bits to the current code and how they affect the current thread code and being affected by it.
So this pull requests aims to predict what is the most relavant CR field to the current code and display it in an intuitive manner.
There is a specialization for STDCX and STWCX. (but other CR0 modifing instructions are currently not being detected)
Example: detected used CR4 field in context.
But when I keep stepping in this code and encounter an instruction using CR7: