Qt: Fix saved log filename #14239
Qt: Fix saved log filename #14239
Conversation
elad335
commented
Jul 21, 2023
•
elad335
commented
- Allow non-english letters.
- Fix missing ']'.
- Deduplicate spaces.
- Show log directory on success to further simplify log finding.
elad335
force-pushed
the
llvm-link
branch
2 times, most recently
from
38a2a32
to
8666b63
Compare
| @@ -2413,6 +2413,12 @@ void main_window::CreateConnects() | |||
| // Try to copy it if fails | |||
| if (fs::copy_file(from, to, true)) | |||
| { | |||
| if (fs::file sync_fd{to, fs::write}) | |||
There was a problem hiding this comment.
I think this should be a param of copy_file.
There was a problem hiding this comment.
This is for the move operation not the copy, it's outside the scope of copy_file. It may be added for rename in the future.
There was a problem hiding this comment.
That doesn't make any sense
There was a problem hiding this comment.
Remove file operation may be ordered before file write. On powerloss, this can result in a loss of log file data.
There was a problem hiding this comment.
This still doesn't explain why you didn't make it an option for copy_file
There was a problem hiding this comment.
Because syncronizing disk file writes is an expensive operation and has very specific use cases. It's better for it not to be in fs::copy_file nor in fs::file::write to avoid misuse.
There was a problem hiding this comment.
That's literally the only reason why you would sync.
And that still doesn't explain why it's not a parameter
There was a problem hiding this comment.
It should be used with caution due to the performance panelty, a programmer can easily use it without giving it too much thought which can be detrimental. Boolean parameter can easily slip in review because it is very subtle. Yes we can add a specially typed constant for it to be very explicit such as file.write(buffer, fs::syncronize_this_write_to_disk) but it seems to be overkill.
