Game List: Add Remove HDD1 Cache option #14250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elad335
changed the title
Megamouse
reviewed
Jul 23, 2023
elad335
force-pushed
the
hdd12
branch
7 times, most recently
from
d5623bf
to
8580f50
Compare
elad335
force-pushed
the
hdd12
branch
3 times, most recently
from
742d4d0
to
c2c4ba6
Compare
Megamouse
reviewed
Jul 23, 2023
elad335
force-pushed
the
hdd12
branch
2 times, most recently
from
4a62df7
to
1c29d65
Compare
Megamouse
reviewed
Jul 23, 2023
rpcs3/rpcs3qt/main_window.cpp
Outdated
Comment on lines
1972
to
1975
| ui->batchCreatePPUCachesAct->setEnabled(false); | ||
| ui->batchRemovePPUCachesAct->setEnabled(false); | ||
| ui->batchRemoveSPUCachesAct->setEnabled(false); | ||
| ui->batchRemoveShaderCachesAct->setEnabled(false); |
There was a problem hiding this comment.
that's not part of the toolbar
Megamouse
reviewed
Jul 23, 2023
rpcs3/rpcs3qt/main_window.cpp
Outdated
Comment on lines
1911
to
1914
| ui->batchCreatePPUCachesAct->setEnabled(false); | ||
| ui->batchRemovePPUCachesAct->setEnabled(false); | ||
| ui->batchRemoveSPUCachesAct->setEnabled(false); | ||
| ui->batchRemoveShaderCachesAct->setEnabled(false); |
There was a problem hiding this comment.
this doesn't make any sense
elad335
force-pushed
the
hdd12
branch
3 times, most recently
from
493aaed
to
f93e395
Compare
|
lgtm. didn't test though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition, fix allowance of caches/games to be removed while the game is still running.
Imagine removing the currently running game lol!