overlays/osk: respect ignore_device_events #14407
Conversation
|
I'll have to think about this properly. |
|
I think this is correct, but I don't remember why I opted for the current code after testing with some of your fellow players. Just for future reference, this is how I believe the logic to be (during seperate windows). So this leads us to the following table:
The |
| return; | ||
|
|
||
| if (!ignore_device_events && input_device.exchange(CELL_OSKDIALOG_INPUT_DEVICE_PAD) != CELL_OSKDIALOG_INPUT_DEVICE_PAD) | ||
| if (input_device.exchange(CELL_OSKDIALOG_INPUT_DEVICE_PAD) != CELL_OSKDIALOG_INPUT_DEVICE_PAD) |
There was a problem hiding this comment.
The check in 656 can now technically be removed.
| return; | ||
|
|
||
| if (!ignore_device_events && input_device.exchange(CELL_OSKDIALOG_INPUT_DEVICE_KEYBOARD) != CELL_OSKDIALOG_INPUT_DEVICE_KEYBOARD) | ||
| if (input_device.exchange(CELL_OSKDIALOG_INPUT_DEVICE_KEYBOARD) != CELL_OSKDIALOG_INPUT_DEVICE_KEYBOARD) |
There was a problem hiding this comment.
The check in 912 can now technically be removed.
In Metal Gear Online there are certain situations where you should be unable to type or use the on screen keyboard, for example when you are stunned/asleep or when transitioning through a loading screen. This change more or less makes the OSK work as it should in MGO, however I'm not sure what real hardware expects or if this affects any of the other games that use native keyboard handling (there aren't many).