Auto-dump binaries (PPU Debug), reduce ELF loader RAM usage #14416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elad335
force-pushed
the
decrypt
branch
6 times, most recently
from
ca084f9
to
b64dfa9
Compare
Megamouse
reviewed
Aug 3, 2023
|
|
||
| if (ppu_load_exec(ppu_exec, false, m_path, DeserialManager())) | ||
| { | ||
| if (g_cfg.core.ppu_debug) | ||
| { |
There was a problem hiding this comment.
Can't you put these spu and ppu debug prog saving sections into functions?
It's getting increasingly worse to read the general flow of these code sections
elad335
force-pushed
the
decrypt
branch
2 times, most recently
from
5da394e
to
cf4e568
Compare
elad335
changed the title
elad335
force-pushed
the
decrypt
branch
2 times, most recently
from
9a6379d
to
72413de
Compare
elad335
changed the title
elad335
changed the title
elad335
force-pushed
the
decrypt
branch
2 times, most recently
from
b998dd7
to
915f30c
Compare
Do not duplicate shdr memory when it is present in phdr.
Megamouse
reviewed
Aug 3, 2023
| // Rely on previous sh_offset value! | ||
| if (hdr.p_offset <= shdr.sh_offset && shdr.sh_offset + shdr.sh_size - 1 <= hdr.p_offset + hdr.p_filesz - 1) | ||
| { | ||
| const auto& prog = ::at32(progs, p_index); |
Megamouse
reviewed
Aug 3, 2023
|
|
||
| for (const auto& hdr : progs) | ||
| { | ||
| if (shdr.bin_view.empty()) |
There was a problem hiding this comment.
why not check this in line 440 ?
Megamouse
reviewed
Aug 3, 2023
| { | ||
| if (out.size() == data.size()) | ||
| { | ||
| // Risky optimization: assume if file size match they are equal and does not need to rewrite it |
There was a problem hiding this comment.
Why does this need such an optimization if it's a debug tool anyway?
There was a problem hiding this comment.
So it would be convenient to use it most of the time, the risks are extremely low and depend on disk errors. The write itself is not atomic so it's not perfect anyways.
There was a problem hiding this comment.
And even if there are errors, common sense says to delete the file and redump it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was the difference in file size when using this dumping code and the decryption tool because elf_object::open/save were not optimized to include inner sections.