vk: Fix detection of RADV on get_driver_vendor() #14432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Mesa 22.2.0 (2022-09-21), commit https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11027/diffs?commit_id=f06da59fd75d7ce7708d159753fcdbc11de16f9e, the deviceName property has included the name of the GPU, thus invalidating our previous method of detecting RADV as a driver vendor Before: "AMD RADV NAVY_FLOUNDER" After: "AMD Radeon RX 6700M (RADV NAVI22)" Before: "AMD RADV RENOIR" After: "AMD Radeon Graphics (RADV RENOIR)"
AniLeo
added
Bugfix
Render: Vulkan
Driver: RADV (Mesa)
kd-11
approved these changes
Aug 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Mesa 22.2.0 (2022-09-21), commit f06da59fd75d7ce7708d159753fcdbc11de16f9e, the deviceName property has included the name of the GPU, thus invalidating our previous method of detecting RADV as a driver vendor.
Because the AMD check looks for "Radeon" and comes before the RADV one, RADV drivers started wrongly being detected as AMD proprietary. The fix is to simply do the RADV check before the AMD one.
Examples:
Before: "AMD RADV NAVY_FLOUNDER"
After: "AMD Radeon RX 6700M (RADV NAVI22)"
Before: "AMD RADV RENOIR"
After: "AMD Radeon Graphics (RADV RENOIR)"