Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PPU SELF Precompilation #14485

Merged
merged 1 commit into from Aug 14, 2023
Merged

Fix PPU SELF Precompilation #14485

merged 1 commit into from Aug 14, 2023

Conversation

elad335
Copy link
Contributor

@elad335 elad335 commented Aug 14, 2023

Thanks for @CookiePLMonster for helping with debugging.

@@ -3249,7 +3249,7 @@ void Emulator::ConfigurePPUCache() const

_main.cache = rpcs3::utils::get_cache_dir();

if (!m_title_id.empty() && m_cat != "1P")
if (!IsPathInisdeDir(m_path, g_cfg_vfs.get_dev_flash()) && !m_title_id.empty() && m_cat != "1P")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IsPathInsideDir

@elad335 elad335 marked this pull request as draft August 14, 2023 10:19
@CookiePLMonster
Copy link
Contributor

image

Doesn't help so far.

@elad335 elad335 force-pushed the patch-1 branch 2 times, most recently from ad9a946 to c3b798c Compare August 14, 2023 14:17
@elad335
Copy link
Contributor Author

elad335 commented Aug 14, 2023

@CookiePLMonster Retest.

@elad335 elad335 marked this pull request as ready for review August 14, 2023 14:45
@elad335 elad335 changed the title Fix PPU cache location for FW SELF Fix PPU SELF Precompilation Aug 14, 2023
Copy link
Contributor

@CookiePLMonster CookiePLMonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue confirmed fixed - PPU no longer creates additional unneeded caches inside game-specific directories, and eboot.bin doesn't compile twice either.

@elad335 elad335 merged commit 968762c into master Aug 14, 2023
5 checks passed
@elad335 elad335 deleted the patch-1 branch August 14, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants