Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Progress Dialog: Fix race when PPU compilation is super fast, RSX #14505 fixup #14533

Merged
merged 2 commits into from Aug 22, 2023
Merged

Progress Dialog: Fix race when PPU compilation is super fast, RSX #14505 fixup #14533

merged 2 commits into from Aug 22, 2023

Conversation

elad335
Copy link
Contributor

@elad335 elad335 commented Aug 22, 2023 •
edited

@elad335 elad335 force-pushed the modulo branch 3 times, most recently from 992ab6f to 8b41b43 Compare August 22, 2023 07:44
@elad335 elad335 force-pushed the modulo branch 3 times, most recently from 7fc8714 to c1d8415 Compare August 22, 2023 08:21
@elad335 elad335 added the Bugfix label Aug 22, 2023
@elad335 elad335 changed the title Progress Dialog: Fix race when PPU compilation is super fast Progress Dialog: Fix race when PPU compilation is super fast, RSX #14505 fixup Aug 22, 2023
@Ordinary205
Copy link
Contributor

Ordinary205 commented Aug 22, 2023 •
edited

Can confirm that this fixes Watch dogs from linking PPU modules, which lasted 1 minute from stopping it.
RPCS3.log.gz

@elad335 elad335 force-pushed the modulo branch 7 times, most recently from a0376ff to 9459fbf Compare August 22, 2023 10:14
@Darkhost1999
Copy link
Contributor

I was testing this #13877
And noticing games like GTAV still have a huge gap in time between PPU and SPU cache while the log appears to just sit there.
Makes the program feel like it crashed or froze and isn't thinking.
I notice more updates and pushes I can test again if it's trying to resolve this issue as well as the watchdogs. They were just suspected to be related.

@elad335
Copy link
Contributor Author

elad335 commented Aug 22, 2023

Yeah this is a LLVM16 bug, we may try to fix it on our side.

@elad335 elad335 merged commit e2d4d40 into RPCS3:master Aug 22, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Regression] PPU loading never finishes for some titles (#13534)
3 participants
@elad335 @Ordinary205 @Darkhost1999