Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPU LLVM: Optimize spu_idisable #14598

Merged
merged 1 commit into from
Sep 1, 2023
Merged

SPU LLVM: Optimize spu_idisable #14598

merged 1 commit into from
Sep 1, 2023

Conversation

elad335
Copy link
Contributor

@elad335 elad335 commented Sep 1, 2023 •
edited
Loading

Do not break blocks on interrupt-disabling branch-to-next. Maybe improves performance in TLoU and some other Sony's exclusives.

Example:
image

@Ordinary205
Copy link
Contributor

Improves performance on RDR, but sadly Demon's Souls got regressed.

Master:
RDR (27.5/28.8/29.4 FPS)

Screenshot

RDR Test 1 (2)

Demon's Souls (70/75.3/76.8 FPS)
Screenshot

Demons Souls FPS Test 1 (2)

PR:
RDR (28.4/29.3/30.2 FPS)

Screenshot

RDR Test 2 (2)

Demon's Souls (68/73.5/76.7 FPS)
Screenshot

Demons Souls FPS Test 2 (2)

@elad335
Copy link
Contributor Author

elad335 commented Sep 1, 2023 •
edited
Loading

It's a bit odd to see performance regressions here, and IIRC demon soul's does not use SPU interrupts. Can you retest just in case?

@elad335 elad335 merged commit f9f2657 into RPCS3:master Sep 1, 2023
6 checks passed
@elad335 elad335 added CPU Optimization Optimizes existing code LLVM Related to LLVM instruction decoders labels Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CPU LLVM Related to LLVM instruction decoders Optimization Optimizes existing code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@elad335 @Ordinary205