[HOTFIX] Do not wait for progress dialog cleanup for SPU Precompilation #14607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elad335
force-pushed
the
savestate-fix
branch
2 times, most recently
from
74072db
to
4929ea5
Compare
This confuses both the user and the developer at times.
Improve sys_prx_load_module and sys_overlay_load_module error checking.
Disable progress dialog for when only precompilation is required.
elad335
force-pushed
the
savestate-fix
branch
from
4929ea5
to
ba46b06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spu_cache::initialize can now be called inside PPU precompilation which creates a deadlock. Avoid the use of progress dialog updates forr SPU Precompilation inside PPU precompilation for now (TODO).
May fix #14605.