rsx: Fix vertex input validation failure #14820
Conversation
- We switched from a allocate-per-draw-call to reusing the vertex input data. We need to make sure previous state does not affect validation results. - Memcpy is too slow at this level of frequency, so just reset the attributes you're using before using them. - Also changes the validation routine to only check attributes we're actually using.
|
Thanks to this PR, I managed to go further on test drive unlimited 2, which no longer crashes the whole emulator before reaching the title screen. |
|
This is a promising development towards resolving #10886 and #12568, as it gets a bit further through the intro screens to the actual title screen as shown above. However, WCB and RCB are both needed to fix severely broken graphics past that point, and with WCB turned on in particular, the game still freezes. Log: RPCS3.log.zip |
Have you tried using Atomic with driver wake-up delay around 200us to fix freezes? Because the game doesn't seem to freeze after 30 minutes of gameplay when using this option. |
|
@Ordinary205 The specific combination of WCB/RCB, atomic and 200us wake-up delay were one of my tests, and unfortunately it still freezes with them (black screen after title with no further progress). I retested again to be sure. |
|
@kd-11 |
This bug is technically a regression. We switched from a allocate-per-draw-call to reusing the vertex input data due to the large performance impact of allocating the struct each draw call (basically millions of times per second in some games). We need to make sure previous state does not affect validation results.
Fixes #14815