rsx: Maintenance improvements #14834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- VS states come before FS mirrors
…than low - Hardware behavior is inconsistent so let's just emulate this when possible
This was referenced Nov 21, 2023
|
Sadly, the OpenGL is still not fixed on Need for Speed Rivals. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. gl: Fix static sampler bindings
VS states come before FS mirrors. The wrong ordering here meant that non-FS samplers were completely fucked in OpenGL since the refactor that made sampler bindings static. Discovered while debugging an unrelated issue. Likely fixes OpenGL bugs in many games depending on the driver used.
2. rsx: Always enable ROP output rounding when shader precision is above low
Force-enables the NVIDIA-specific workaround for all vendors. It appears there is too much variability between hardware vendors to count on a specific behavior.
Fixes #14788