Qt: Post Game-Installation Assistant #14864

elad335 · 2023-12-02T16:07:46Z

New Features

"Add Games" would now prompt the post-install assistant, which was previously only done when installing game packages.
I added the option to precompile CPU caches right after installation for your convenience. Preventing the wait on boot before first boot when you actually want to play the game!

rpcs3/rpcs3qt/main_window.cpp

rpcs3/rpcs3qt/game_list_frame.h

Megamouse · 2023-12-02T21:20:55Z

rpcs3/rpcs3qt/main_window.cpp

+	vlayout->addWidget(btn_box);
+	dlg->setLayout(vlayout);
+
+	connect(btn_box, &QDialogButtonBox::accepted, this, [this, dlg, desk_check, quick_check, precompile_check, bootable_paths = std::move(bootable_paths)]()


This dialog should be its own class that connects to this main window function instead of adding more and more and more nested dialog code to big classes like this.

Megamouse · 2023-12-05T20:00:18Z

rpcs3/rpcs3qt/main_window.cpp

 		{
-			if (bootable_paths_installed.empty())
+			m_game_list_frame->AddRefreshedSlot([paths = std::move(bootable_paths_installed)]() mutable


Suggested change

m_game_list_frame->AddRefreshedSlot([paths = std::move(bootable_paths_installed)]() mutable

connect(m_game_list_frame, &game_list_frame::Refreshed, this, func, Qt::SingleShotConnection);

That's cool!

Megamouse · 2023-12-05T20:00:53Z

rpcs3/rpcs3qt/main_window.cpp


 			for (const QString& path : paths)
 			{
 				AddGamesFromDir(path);
 			}
+
+			m_game_list_frame->AddRefreshedSlot([paths = std::move(paths), existing = std::move(existing)]()


Suggested change

m_game_list_frame->AddRefreshedSlot([paths = std::move(paths), existing = std::move(existing)]()

connect(m_game_list_frame, &game_list_frame::Refreshed, this, func, Qt::SingleShotConnection);

Megamouse · 2023-12-05T20:01:33Z

rpcs3/rpcs3qt/main_window.cpp

+
+			for (const game_info& game : m_game_list_frame->GetGameInfo())
+			{
+				if (game)


Suggested change

if (game)

if (!game) continue;

Megamouse · 2023-12-05T20:02:39Z

rpcs3/rpcs3qt/main_window.cpp

+
+				for (const game_info& game : m_game_list_frame->GetGameInfo())
+				{
+					if (game && !existing.contains(game->info.path))


Suggested change

if (game && !existing.contains(game->info.path))

if (!game || existing.contains(game->info.path)) continue;

Megamouse · 2023-12-05T20:12:06Z

rpcs3/rpcs3qt/game_list_frame.h

@@ -8,6 +8,7 @@
 #include "Utilities/mutex.h"
 #include "Emu/config_mode.h"

+


Megamouse · 2023-12-05T20:23:17Z

rpcs3/rpcs3qt/main_window.cpp

-			{
-				locations.insert(gui::utils::shortcut_location::applications);
-			}
+		std::this_thread::sleep_for(std::chrono::microseconds(100'000 - std::min<usz>(100'000, get_system_time() - start_time)));


What is this for again?
Please add a comment.

I think it's so you had the 100% state seen for a little while, but this was in addition to the full refresh afterwards so it wasn't very efficient

Megamouse · 2023-12-05T20:37:57Z

rpcs3/rpcs3qt/main_window.cpp

+
+		if (!cancelled)
+		{
+			return true;


this is placebo. we already return true in this scope no matter what

Megamouse · 2023-12-05T20:40:51Z

rpcs3/rpcs3qt/main_window.cpp

@@ -1095,80 +1095,30 @@ bool main_window::HandlePackageInstallation(QStringList file_paths, bool from_bo
 			bootable_paths_installed[bootable_paths[index]] = packages[index].title_id;
 		}

-		pdlg.hide();
+		const bool installed_a_whole_package_without_new_software = bootable_paths_installed.empty() && !cancelled;


Needs a comment which explains the early check (due to move)

oltolm · 2023-12-11T16:40:55Z

rpcs3/rpcs3qt/main_window.cpp

+	vlayout->addWidget(btn_box);
+	dlg->setLayout(vlayout);
+
+	connect(btn_box, &QDialogButtonBox::accepted, this, [=, paths = std::move(bootable_paths)]()


I get this warning from Clang.

[550/577] Building CXX object rpcs3/rpcs3qt/CMakeFiles/rpcs3_ui.dir/main_window.cpp.obj C:/src/rpcs3/rpcs3/rpcs3qt/main_window.cpp:2318:37: warning: implicit capture of 'this' with a capture default of '=' is deprecated [-Wdeprecated-this-capture] 2318 | for (const game_info& gameinfo : m_game_list_frame->GetGameInfo()) | ^ C:/src/rpcs3/rpcs3/rpcs3qt/main_window.cpp:2290:55: note: add an explicit capture of 'this' to capture '*this' by reference 2290 | connect(btn_box, &QDialogButtonBox::accepted, this, [=, paths = std::move(bootable_paths)]() | ^ | , this 1 warning generated.

Augusto7743 · 2023-12-11T22:55:12Z

THANKS VERY MUCH !!!!!

elad335 added Enhancement GUI labels Dec 2, 2023

elad335 force-pushed the save-breathe branch from f246f03 to 106a2f4 Compare December 2, 2023 16:15

Megamouse reviewed Dec 2, 2023

View reviewed changes

elad335 force-pushed the save-breathe branch 3 times, most recently from edbd142 to cf62505 Compare December 5, 2023 19:29

Megamouse reviewed Dec 5, 2023

View reviewed changes

rpcs3/rpcs3qt/game_list_frame.h Outdated

@@ -8,6 +8,7 @@

#include "Utilities/mutex.h"

#include "Emu/config_mode.h"

Copy link

Contributor

Megamouse Dec 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

empty line

Megamouse reviewed Dec 5, 2023

View reviewed changes

elad335 force-pushed the save-breathe branch 5 times, most recently from ecb2301 to 0678ff6 Compare December 10, 2023 19:54

Qt: Post Game-Installation Assistant

cfe03e0

elad335 force-pushed the save-breathe branch from 0678ff6 to cfe03e0 Compare December 11, 2023 04:34

elad335 merged commit a6839e8 into RPCS3:master Dec 11, 2023
4 of 6 checks passed

oltolm reviewed Dec 11, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Qt: Post Game-Installation Assistant #14864

Qt: Post Game-Installation Assistant #14864

elad335 commented Dec 2, 2023

Megamouse Dec 2, 2023

Megamouse Dec 5, 2023

elad335 Dec 5, 2023

Megamouse Dec 5, 2023

Megamouse Dec 5, 2023

Megamouse Dec 5, 2023

Megamouse Dec 5, 2023

Megamouse Dec 5, 2023

elad335 Dec 5, 2023 •

edited

Megamouse Dec 5, 2023

Megamouse Dec 5, 2023

oltolm Dec 11, 2023

Augusto7743 commented Dec 11, 2023

	m_game_list_frame->AddRefreshedSlot([paths = std::move(bootable_paths_installed)]() mutable
	connect(m_game_list_frame, &game_list_frame::Refreshed, this, func, Qt::SingleShotConnection);

	if (game && !existing.contains(game->info.path))
	if (!game \|\| existing.contains(game->info.path)) continue;

		@@ -8,6 +8,7 @@
		#include "Utilities/mutex.h"
		#include "Emu/config_mode.h"

Qt: Post Game-Installation Assistant #14864

Qt: Post Game-Installation Assistant #14864

Conversation

elad335 commented Dec 2, 2023

New Features

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elad335 Dec 5, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Augusto7743 commented Dec 11, 2023

elad335 Dec 5, 2023 •

edited