Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rsx: Let 308a::color have a synchronization side-effect in strict mode #14880

Merged
merged 2 commits into from Dec 9, 2023
Merged

rsx: Let 308a::color have a synchronization side-effect in strict mode #14880

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1200497
rsx: Let 308a::color have a synchronization side-effect in strict mode
kd-11 Dec 8, 2023
165e6af
rsx: Improve strict mode check in 308a::color
kd-11 Dec 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 7 additions & 0 deletions rpcs3/Emu/RSX/rsx_methods.cpp
View file
Open in desktop
Expand Up @@ -1054,6 +1054,13 @@ namespace rsx
// Skip "handled methods"
rsx->fifo_ctrl->skip_methods(count - 1);

// 308A::COLOR can be used to create custom sync primitives.
// Hide this behind strict mode due to the potential performance implications.
if (count == 1 && g_cfg.video.strict_rendering_mode && !g_cfg.video.relaxed_zcull_sync)
{
rsx->sync();
}

switch (*method_registers.blit_engine_nv3062_color_format())
{
case blit_engine::transfer_destination_format::a8r8g8b8:
Expand Down