sceNp/vm: Fix strings read, implement safe string reader #14885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe just make it a string wrapper class that evaluates to false if it can't be built properly? |
elad335
force-pushed
the
save-breathe
branch
8 times, most recently
from
9de819f
to
7aff961
Compare
|
Can confirm that it resolves this issue on Full Auto 2 demo. |
Megamouse
reviewed
Dec 11, 2023
| @@ -3530,7 +3527,7 @@ void main_window::AddGamesFromDirs(const QStringList& paths) | |||
| Emu.AddGamesFromDir(sstr(path)); | |||
| } | |||
|
|
|||
| m_game_list_frame->AddRefreshedSlot<class KeyType>([this, paths = std::move(paths), existing = std::move(existing)](std::set<QString>& IDs) | |||
| m_game_list_frame->AddRefreshedSlot([this, paths = std::move(paths), existing = std::move(existing)](std::set<std::string>& claimed_paths) | |||
There was a problem hiding this comment.
The move here is the main culprit
elad335
force-pushed
the
save-breathe
branch
2 times, most recently
from
d0c7887
to
5478dd4
Compare
elad335
force-pushed
the
save-breathe
branch
2 times, most recently
from
d964dc4
to
94d05d2
Compare
Use paths instead of IDs, disable typemap.
elad335
force-pushed
the
save-breathe
branch
from
94d05d2
to
d54c09c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to fix #14882, introduce a safe string reader.