overlays: convert debug overlay to native overlay #14894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Megamouse
commented
Dec 14, 2023
Megamouse
commented
- Unifies the debug overlay to a native overlay and removes redundant text writer classes.
Megamouse
force-pushed
the
debug_overlay
branch
7 times, most recently
from
37538af
to
c76a6c3
Compare
Megamouse
force-pushed
the
debug_overlay
branch
from
eaa82fd
to
39aab0d
Compare
kd-11
reviewed
Dec 20, 2023
| @@ -763,32 +764,6 @@ void VKGSRender::flip(const rsx::display_flip_info_t& info) | |||
|
|
|||
| if (g_cfg.video.overlay) | |||
| { | |||
| // TODO: Move this to native overlay! It is both faster and easier to manage | |||
There was a problem hiding this comment.
Lol. My laziness strikes again.
kd-11
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.