Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for 0.0.30 #14959

Merged
merged 18 commits into from Jan 1, 2024
Merged

Fixes for 0.0.30 #14959

merged 18 commits into from Jan 1, 2024

Conversation

elad335
Copy link
Contributor

@elad335 elad335 commented Dec 29, 2023

  • Fix an optimization miss in SPU LLVM when using GPR barriers.
  • Fix TAR serialization for individual files if they need to be processed in more than 1 iteration due to their size.
  • Don't block the compression-requesting thread until all bytes are processed and written to file, instead free the thread the moment it can continue execution in order to improve saving performance.
  • Fix an infinite loop in compression thread.
  • Fix lv2_timer_thread abort
  • Fix pad_state_notify_state_change
  • Make bf_t<T> warning-friendly by using small integers when possible.
  • Add cellPad event when registering LDD pads.
  • Do not rely solely on value-inequality in sys_spu, this can cause a theoretical bug when overflows.

@elad335 elad335 added Bugfix Savestates Anything that involves savestates LLVM Related to LLVM instruction decoders labels Dec 29, 2023
@elad335 elad335 force-pushed the dump-ptr branch 6 times, most recently from 5551eff to 3e38c8c Compare December 30, 2023 02:46
@DAOWAce
Copy link

DAOWAce commented Dec 30, 2023

Assuming this currently fixes the issue, can it get merged ASAP? Savestates are pretty much completely broken [for me] right now and I cannot get it to save after 10 attempts in a row. Adjusting SPU-compat doesn't fix. Snip:

F {Emu State Capture Thread: ''} SIG: Thread terminated due to fatal error: Narrowing error
(in file D:\a\1\s\rpcs3\util\atomic.hpp:1697[:39], in function wait)
E SYS: Saving savestate failed due to fatal error!
SIG: Thread [Compressed File Writer Thread] is too sleepy. Waiting for it 273369553.555µs already!

Addendum: Before the recent reworks to savestates, it almost always worked but would occasionally crash if saving again after loading without restarting emu, but now it's 99% broken. Had it save once a few days ago, but loading it resulted in a 10FPS black screen.

@elad335
Copy link
Contributor Author

elad335 commented Dec 30, 2023

This is a new issue, I think it is one of the warning fixes

@elad335 elad335 merged commit 87140ab into RPCS3:master Jan 1, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix LLVM Related to LLVM instruction decoders Savestates Anything that involves savestates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants