Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rsx: Fix RSX tiling when using optimized DMA views #14985

Merged
merged 3 commits into from Jan 1, 2024
Merged

Conversation

kd-11
Copy link
Contributor

@kd-11 kd-11 commented Dec 31, 2023

Allows tiled targets to work properly with linear DMA sections. This keeps performance up while allowing the detiler to work properly.

Closes #14984

@Linear524
Copy link

Thank you, KD-11, for all your RSX bugfixing work ! :)
Any ideas how to fix remaining GPU side tiling bugs ?)

@kd-11
Copy link
Contributor Author

kd-11 commented Jan 1, 2024

Thank you, KD-11, for all your RSX bugfixing work ! :) Any ideas how to fix remaining GPU side tiling bugs ?)

There is a roadmap for some of the major remaining issues. Some outliers may remain but we'll just have to fix them one at a time.

@kd-11 kd-11 merged commit 6c33c38 into RPCS3:master Jan 1, 2024
6 checks passed
@legend800
Copy link

legend800 commented Jan 1, 2024

Just posted in the other thread that this PR broke Split Second gfx: #14682 (comment)

It was fine(ish) on the previous Master build and now broken on the build that just came out a couple mins ago:

2024-01-01 09_34_50-FPS_ 30 00 _ Vulkan _ 0 0 29-15899 _ Split_Second  NPUB30450

Previous build (exact same settings):
2024-01-01 09_15_17-

@legend800
Copy link

legend800 commented Jan 21, 2024

@kd-11 Did you see this comment here: #14984 (comment)?

Game was not improved and this PR only regressed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] RSX tiling breaks visual effects in Split/Second at 100% render scale
4 participants