Fix games.yml hdd paths #14995
Merged
Fix games.yml hdd paths #14995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested with a ps1 game and it still works. |
elad335
reviewed
Jan 2, 2024
|
|
||
| if (begin == source.npos) | ||
| return {}; | ||
|
|
||
| return source.substr(begin, source.find_last_not_of(values) + 1); | ||
| } | ||
|
|
||
| std::string fmt::trim_front(const std::string& source, std::string_view values) |
There was a problem hiding this comment.
I think it's better to return a string view, or at least have two functions like fs::get_parent_dir_view
There was a problem hiding this comment.
Well, if it ever is necessary we can add it. But for this PR it hardly matters at all
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
probably fixes #14994