Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Savestate and filesystem fixes #15049

Merged
merged 9 commits into from Jan 20, 2024
Merged

Savestate and filesystem fixes #15049

merged 9 commits into from Jan 20, 2024

Conversation

elad335
Copy link
Contributor

@elad335 elad335 commented Jan 15, 2024

  • Fixup HDD1 corruption detection.
  • Fixup a minor bug in PPU module compilation overlay hint.
  • Optimize PS3 filesystem reads when possible by using complete reads.
  • Early protection againt space shortage when installing PUP (avoid incomplete installation).
  • Fix P2P sockets saving for save-states.

@elad335 elad335 changed the title Filesystem fixes [WIP] Savestate and filesystem fixes Jan 20, 2024
@elad335 elad335 added the Optimization Optimizes existing code label Jan 20, 2024
Add a new menu button for explicit exit (mostly for debug purposes)
@elad335 elad335 merged commit f19744a into RPCS3:master Jan 20, 2024
4 of 6 checks passed
@@ -962,7 +962,7 @@ settings_dialog::settings_dialog(std::shared_ptr<gui_settings> gui_settings, std
const std::string selected_device = m_emu_settings->GetSetting(emu_settings_type::AudioDevice);
int device_index = 0;

for (const audio_device_enumerator::audio_device& dev : dev_array)
for (auto& dev : dev_array)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why was this changed?

@@ -2308,9 +2308,6 @@ settings_dialog::settings_dialog(std::shared_ptr<gui_settings> gui_settings, std
m_emu_settings->EnhanceCheckBox(ui->disableVertexCache, emu_settings_type::DisableVertexCache);
SubscribeTooltip(ui->disableVertexCache, tooltips.settings.disable_vertex_cache);

m_emu_settings->EnhanceCheckBox(ui->forceHwMSAAResolve, emu_settings_type::ForceHwMSAAResolve);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why was this removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By mistake, feel free to fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants