Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add limited support for midi drums w/ rockband 3 #15054

Merged
merged 16 commits into from Feb 13, 2024
Merged

Add limited support for midi drums w/ rockband 3 #15054

merged 16 commits into from Feb 13, 2024

Commits on Feb 11, 2024

  1. add support for midi drums

    @nswarm
    nswarm committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    b51e237 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Megamouse <studienricky89@googlemail.com>
    @nswarm @Megamouse
    nswarm and Megamouse committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    2d01703 View commit details
    Browse the repository at this point in the history

  3. rb3drums: more pr feedback + fix build from github commits

    @nswarm
    nswarm committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    c013d18 View commit details
    Browse the repository at this point in the history

  4. rb3drums: use dpad to disambiguate cymbal/drum hits instead of stagge… 

    …ring.
    @nswarm
    nswarm committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    85ea339 View commit details
    Browse the repository at this point in the history

  5. rb3drums: configurable min velocity and hihat up behavior

    @nswarm
    nswarm committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    502e6d1 View commit details
    Browse the repository at this point in the history

  6. rb3drums: configurable combos, combo duration, note overrides

    @nswarm
    nswarm committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    4888fae View commit details
    Browse the repository at this point in the history

  7. rb3drums: change c cast to static_cast

    @nswarm
    nswarm committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    3c0379c View commit details
    Browse the repository at this point in the history

  8. Apply suggestions from code review 

    Co-authored-by: Megamouse <studienricky89@googlemail.com>
    @nswarm @Megamouse
    nswarm and Megamouse committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    dd06c85 View commit details
    Browse the repository at this point in the history

  9. rb3drums: move config to separate file.

    @nswarm
    nswarm committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    611e222 View commit details
    Browse the repository at this point in the history

  10. rb3drums: apply stagger to double cymbal hits

    @nswarm
    nswarm committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    9ae7ff5 View commit details
    Browse the repository at this point in the history

  11. rb3drums: support midi CC note mapping

    @nswarm
    nswarm committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    e7eb8d9 View commit details
    Browse the repository at this point in the history

  12. rb3drums: add config to cmakelists. only load rb3drums config once.

    @nswarm
    nswarm committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    3880ebd View commit details
    Browse the repository at this point in the history

  13. rb3drums: use flag to load

    @nswarm
    nswarm committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    ac9051e View commit details
    Browse the repository at this point in the history

  14. rb3drums: HihatWithPedalUp defaults to yellow cymbal instead of blue

    @nswarm
    nswarm committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    cae5136 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2024

  1. Merge branch 'master' into midi-drums

    @Megamouse
    Megamouse committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    77dc16d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into midi-drums

    @Megamouse
    Megamouse committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    bb6f290 View commit details
    Browse the repository at this point in the history