Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sceNp: Invitation dialog improvements #15141

Merged
merged 7 commits into from Feb 3, 2024
Merged

Conversation

Megamouse
Copy link
Contributor

@Megamouse Megamouse commented Feb 3, 2024

  • Implements sceNpBasicRecvMessageAttachment, which shows a list of messages (hopefully correct)
  • Implements sceNpBasicAbortGui
  • Adds a confirmation dialog to the invite list. The dialog now shows the subject and body you are about to send.
  • Fixes some new warning in np_handler

image

who the heck thought returning signed on a counter makes sense...
@carlmylo
Copy link

carlmylo commented Feb 3, 2024

Testing with Rock Band 3. The invites show up in the messaging system now. However, I get E {PPU[0x1000000] Thread (main_thread) [HLE:0x011d1504, LR:0x008cfb98]} SYS: 'sceNpBasicRecvMessageAttachmentLoad' failed with 0x8002a673 : SCE_NP_BASIC_ERROR_INVALID_DATA_ID [1] when trying to join the invite.
image

Hopefully I'm commenting on the right one this time. Kinda new to testing these builds for RPCS3.

@Megamouse Megamouse changed the title sceNp: Implement sceNpBasicRecvMessageAttachment sceNp: Implement sceNpBasicRecvMessageAttachment and sceNpBasicAbortGui Feb 3, 2024
@Megamouse Megamouse changed the title sceNp: Implement sceNpBasicRecvMessageAttachment and sceNpBasicAbortGui sceNp: Invitation dialog improvements Feb 3, 2024
@Megamouse
Copy link
Contributor Author

Testing with Rock Band 3. The invites show up in the messaging system now. However, I get E {PPU[0x1000000] Thread (main_thread) [HLE:0x011d1504, LR:0x008cfb98]} SYS: 'sceNpBasicRecvMessageAttachmentLoad' failed with 0x8002a673 : SCE_NP_BASIC_ERROR_INVALID_DATA_ID [1] when trying to join the invite. image

Hopefully I'm commenting on the right one this time. Kinda new to testing these builds for RPCS3.

Do you have a log file of this issue?
I'm interested in the id that is used in that function.

@Megamouse
Copy link
Contributor Author

It's probably working now @carlmylo

@knvtva
Copy link

knvtva commented Feb 3, 2024

I'll give it a test as soon as it's built. Mainly cause then I need to implement the code into the actual server!

@knvtva
Copy link

knvtva commented Feb 3, 2024

Okay, so the game didn't proceed to join. Here's my log
RPCS3.log

@knvtva
Copy link

knvtva commented Feb 3, 2024

My bad, This is an error on my behalf and I didn't notice that my custom server logged an error

@Megamouse Megamouse marked this pull request as ready for review February 3, 2024 16:58
@Megamouse Megamouse merged commit d5ce4e0 into RPCS3:master Feb 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants