SPU LLVM: Allow swapped FMA and multiplications args in match context #15162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
elad335
commented
Feb 6, 2024
elad335
commented
- Allow expression matching when arguments are swapped in some expressions. For example, in multiplication, which a * b = b * a,this should help keep the code clean while adding new instruction pattersn without actually adding anything, just correcting the previous code to support both arguments ordering.
elad335
added
Optimization
elad335
changed the title
elad335
force-pushed
the
llvm-match
branch
2 times, most recently
from
09cafd8
to
0d6229c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.