Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cellRtc: implement remaining parsers, improve formatters #15451

Merged
merged 7 commits into from
Apr 20, 2024
Merged

cellRtc: implement remaining parsers, improve formatters #15451

merged 7 commits into from
Apr 20, 2024

Conversation

capriots
Copy link
Contributor

@capriots capriots commented Apr 14, 2024 •
edited
Loading

  • Full implementation of asctime() and RFC2822 parsers
  • cellRtcParseRfc3339():
    • Moved digit() out of the function, I'm using it for the other parsers as well
  • cellRtcFormatRfc2822() + cellRtcFormatRfc3339():
    • Removed wrong pUtc->tick == 0 check, this is actually a nullptr check on LLE
    • Replaced snpintf() with simple num + '0'
    • Simplified time zone formatting
  • Set log level to notice

@Megamouse
Copy link
Contributor

I'll probably review it tomorrow or so

Megamouse
Megamouse reviewed Apr 16, 2024
View reviewed changes
rpcs3/Emu/Cell/Modules/cellRtc.cpp Outdated Show resolved Hide resolved
rpcs3/Emu/Cell/Modules/cellRtc.cpp Show resolved Hide resolved
rpcs3/Emu/Cell/Modules/cellRtc.cpp Outdated Show resolved Hide resolved
@Megamouse
Copy link
Contributor

Haven't had time to review cellRtcParseDateTime yet.
Maybe tomorrow

Megamouse
Megamouse reviewed Apr 20, 2024
View reviewed changes
rpcs3/Emu/Cell/Modules/cellRtc.cpp Outdated Show resolved Hide resolved
rpcs3/Emu/Cell/Modules/cellRtc.cpp Outdated Show resolved Hide resolved
rpcs3/Emu/Cell/Modules/cellRtc.cpp Outdated Show resolved Hide resolved
rpcs3/Emu/Cell/Modules/cellRtc.cpp Outdated Show resolved Hide resolved
rpcs3/Emu/Cell/Modules/cellRtc.cpp Outdated Show resolved Hide resolved
rpcs3/Emu/Cell/Modules/cellRtc.cpp Outdated Show resolved Hide resolved
rpcs3/Emu/Cell/Modules/cellRtc.cpp Show resolved Hide resolved
rpcs3/Emu/Cell/Modules/cellRtc.cpp Outdated Show resolved Hide resolved
rpcs3/Emu/Cell/Modules/cellRtc.cpp Show resolved Hide resolved
@Megamouse Megamouse merged commit dfec577 into RPCS3:master Apr 20, 2024
4 of 6 checks passed
@capriots capriots deleted the cellRtc2 branch April 20, 2024 13:45
wahahasunk pushed a commit to wahahasunk/rpcs3 that referenced this pull request May 4, 2024
@capriots @wahahasunk
cellRtc: implement remaining parsers, improve formatters (RPCS3#15451)
bac573c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Megamouse Megamouse Megamouse left review comments

Assignees
No one assigned
Labels
Firmware: HLE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@capriots @Megamouse