Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NVIDIA TESTERS NEEDED] rsx: Improve ROP output rounding precision #15471

Merged
merged 2 commits into from Apr 17, 2024
Merged

[NVIDIA TESTERS NEEDED] rsx: Improve ROP output rounding precision #15471

merged 2 commits into from Apr 17, 2024

Conversation

kd-11
Copy link
Contributor

@kd-11 kd-11 commented Apr 17, 2024

  • Lower 12 bits seem to be unused based on empirical sampling.

Fixes #15063

@kd-11
rsx: Improve ROP output rounding precision
6054ea6 
- Lower 12 bits seem to be unused based on empirical sampling
@kd-11
rsx: Make const explicitly unsigned
9960a0d 
- Can silence some GLSL compiler noise in mesa
This was referenced Apr 17, 2024
Closed
Open
@JimScript
Copy link

Well it seems like this fully fixes issue #15063:
BCUS98124_screenshot_2024_04_16_17_54_02

But it seems like issue #10754 is in fact a different problem, as it's not fixed or changed by this PR in any way:
BCUS98127_screenshot_2024_04_16_17_55_58

@cipherxof
Copy link
Contributor

cipherxof commented Apr 17, 2024 •
edited

No obvious issues with MGS4.

OS: Arch Linux
GPU: RTX 3080

@kd-11
Copy link
Contributor Author

kd-11 commented Apr 17, 2024

Thanks for testing.

@kd-11 kd-11 merged commit 40eda1b into RPCS3:master Apr 17, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ratchet & Clank Future: A Crack in Time and Resistance 2's foliage is broken on Windows
3 participants
@kd-11 @JimScript @cipherxof