cellRtc: misc. improvements, set to HLE by default #15496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
capriots
commented
Apr 21, 2024
capriots
commented
- Fixed hopefully any inaccuracies that were left
- Stubbed two syscalls used in cellRtc
- Simplified a bunch of functions, especially cellRtcTickAddMonths() and cellRtcTickAddYears()
- Implemented the rest of cellRtcGetCurrentSecureTick()
- To fix Ghidra's decompilation you need to nop the instructions at 0x3b20 and 0x3b24 (removes the initializers for two variables)
- Added sanity checks where there are no nullptr checks on LLE
- Moved constants into header file
- Removed unused functions
- Replaced vm::check_addr() with sys_memory_get_page_attribute() everywhere to be more accurate to LLE
- Set log level to notice everywhere (trace if I found a game where it was being spammed)
elad335
reviewed
Apr 21, 2024
| } | ||
|
|
||
| error_code cellRtcIsLeapYear(s32 year) | ||
| { | ||
| cellRtc.todo("cellRtcIsLeapYear(year=%d)", year); | ||
| cellRtc.notice("cellRtcIsLeapYear(year=%d)", year); |
There was a problem hiding this comment.
just set them all to trace, syscalls are already logged anyways.
elad335
reviewed
Apr 21, 2024
| @@ -268,10 +268,10 @@ const std::array<std::pair<ppu_intrp_func_t, std::string_view>, 1024> g_ppu_sysc | |||
| BIND_SYSC(sys_event_port_connect_ipc), //140 (0x08C) | |||
| BIND_SYSC(sys_timer_usleep), //141 (0x08D) | |||
| BIND_SYSC(sys_timer_sleep), //142 (0x08E) | |||
| NULL_FUNC(sys_time_set_timezone), //143 (0x08F) ROOT | |||
| BIND_SYSC(sys_time_set_timezone), //143 (0x08F) ROOT | |||
There was a problem hiding this comment.
This is a root syscall though, games do not have access to it.
There was a problem hiding this comment.
They are used in cellRtc, so I need them defined as a function. Do you want me to add a root check?
|
I'll review the rtc changes sometime this week. |
Megamouse
reviewed
Apr 27, 2024
rpcs3/Emu/Cell/Modules/cellRtc.cpp
Outdated
Comment on lines
1388
to
1401
| if (ret >= CELL_OK) | ||
| { | ||
| tick->tick += *time * cellRtcGetTickResolution(); | ||
| } | ||
| else if (ret == static_cast<s32>(SYS_SS_RTC_ERROR_UNK)) | ||
| { | ||
| switch (*status) | ||
| { | ||
| case 1: ret = CELL_RTC_ERROR_NO_CLOCK; break; | ||
| case 2: ret = CELL_RTC_ERROR_NOT_INITIALIZED; break; | ||
| case 4: ret = CELL_RTC_ERROR_INVALID_VALUE; break; | ||
| case 8: ret = CELL_RTC_ERROR_NO_CLOCK; break; | ||
| } | ||
| } |
There was a problem hiding this comment.
I can't really verify this. maybe my analyser is borked. But whatever...
There was a problem hiding this comment.
Right click the instruction at 0x3b20 > click "Patch Instruction" > type in ori r0,r0,0
Do the same for the next instruction
There was a problem hiding this comment.
missing default in switch btw
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.