New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rsx/gl/vk/dx12: Add emulated texture fetch for depth read #2173
Conversation
gl/vk/dx12: Simplify reinterpretation equation
@kd-11, thanks for your PR! By analyzing the annotation information on this pull request, we identified @vlj, @raven02 and @Nekotekina to be potential reviewers |
@SakataGintokiYT Please check if it fixes depth problems with naruto. The bad shadows are due to a different issue since they appear earlier on in the draw call, before this particular issue starts. I've analyzed traces from 3 naruto games and they all seem to use the same pattern. |
@kd-11 [GL]
|
Seems like nvidia compiler doesnt like automatic cast from unsigned int to float. |
Should be fixed now |
@kd-11 It's good for merge. |
@kd-11 .Let me know if it is okay to merge. |
Should be good to merge if there are no regressions reported. |
#1949
In theory, this allows reading a depth texture into RGBA8 without losing precision. Directly storing depth values into 8-bit textures loses some precision that is hopefully fixed by this.