-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc changes #2309
Misc changes #2309
Conversation
@@ -31,4 +34,5 @@ install: | |||
|
|||
artifacts: | |||
- path: bin | |||
name: rpcs3-$(configuration)-$(COMMIT_SHA) | |||
name: 'rpcs3-v0.0.1-$(COMMIT_SHA)_$(Date)_win64' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest to swap SHA and Date (so date is before sha), so if there are several builds on the same day, it'd be easier to sort them by name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, the reason I did it like that was to prevent people from copying the version until the date and leaving out the SHA when reporting stuff, but it can easily be swapped.
One could also remove the dashes in the date (so yyyymmdd instead of yyyy-mm-dd) to reduce filename size but I do believe it looks better with dashes.
case b_id_website: wxLaunchDefaultBrowser("http://rpcs3.net/"); break; | ||
case b_id_forum: wxLaunchDefaultBrowser("http://www.emunewz.net/forum/forumdisplay.php?fid=162"); break; | ||
case b_id_website: wxLaunchDefaultBrowser("https://rpcs3.net/"); break; | ||
case b_id_forum: wxLaunchDefaultBrowser("http://www.emunewz.net/forum/forumdisplay.php?fid=172"); break; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't think Good Idea for add Patreon here ? ^^
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Someone can do it later, I don't know how to resize buttons properly.
AppVeyor: Improve artifact name Travis: Update notification email README: Fix forum link and remove coveralls sceNp2: Use UNIMPLEMENTED_FUNC macro instead of fmt::throw_exception VK: Fix pathing for linux AboutDialog: Fix forum link
AppVeyor: Improve artifact name
Travis: Update notification email
Readme: Fix forum link and remove coveralls
sceNp2: Use UNIMPLEMENTED_FUNC macro instead of fmt::throw_exception
VK: Fix pathing for linux
AboutDialog: Fix forum link