Update cellSpudll #2651
Merged
Update cellSpudll #2651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
scribam
commented
Apr 7, 2017
scribam
commented
- Stub cellSpudllGetImageSize
- Implement cellSpudllHandleConfigSetDefaultValues
- Stub cellSpudllGetImageSize - Implement cellSpudllHandleConfigSetDefaultValues
|
@scribam, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Nekotekina, @vlj and @O1L to be potential reviewers. |
scribam
commented
Apr 7, 2017
| config->numMaxReferred = 16; | ||
| config->unresolvedSymbolValueForFunc = vm::null; | ||
| config->unresolvedSymbolValueForObject = vm::null; | ||
| config->unresolvedSymbolValueForOther = vm::null; |
There was a problem hiding this comment.
Not sure about these three lines above. I have wanted to use NULL but found vm::null instead. Is that correct ?
There was a problem hiding this comment.
It's ok. Note that using namespace ps3; should only be used in cpp files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.