Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis fix #2669

Merged
merged 1 commit into from Apr 10, 2017
Merged

Travis fix #2669

merged 1 commit into from Apr 10, 2017

Conversation

Nekotekina
Copy link
Member

No description provided.

@mention-bot
Copy link

@Nekotekina, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Chocobo1, @danilaml and @Bigpet to be potential reviewers.

@Nekotekina Nekotekina force-pushed the master branch 3 times, most recently from a8a92c0 to 6e073cd Compare April 10, 2017 16:14
@danilaml
Copy link
Contributor

danilaml commented Apr 10, 2017

Is it even worth it to have prebuilt rpcs3 binaries for linux? It'll only work properly if they are used in the same environment as on travis anyway. Also, trying to use GitHub Releases functionality for uploading every commit (by adding fake tags) is not ideal either. Does rpcs3.net have any FTP that can be used for that?

@Nekotekina Nekotekina force-pushed the master branch 2 times, most recently from 3b63d8a to a904e86 Compare April 10, 2017 17:01
@hcorion
Copy link
Member

hcorion commented Apr 10, 2017

@danilaml What do you mean? The "same environment" is not that much different from 99% of windows installs. The builds done by travis would be the exact same as builds done using GitHub releases.

@MrSapps
Copy link

MrSapps commented Apr 10, 2017

@danilaml I would also like to know what that means? Seems a bit of a silly statement to say software compiled by MSVC on travis can only run on travis? The only issue should be that people have to install the MSVC runtimes. And if that is a huge issue then you can statically link it.

Edit: Erm by travis I mean appveyor in this instance of course ;)

@danilaml
Copy link
Contributor

@hcorion what windows environments have to do with this? And what is your comment about travis and GitHub releases about?
@paulsapps wut? Is this some kind of backwards day today? MSVC on Travis? wtf?

@hcorion
Copy link
Member

hcorion commented Apr 10, 2017

@danilaml

"Is it even worth it to have prebuilt rpcs3 binaries for windows? It'll only work properly if they are used in the same environment as on travis anyway."

(emphasis mine)

Your original question is odd and doesn't make any sense.

@danilaml
Copy link
Contributor

Your original question is odd and doesn't make any sense.

I swear it wasn't me. It was angry gremlins that butcher my GitHub comments! Obviously I was talking about linux, since it's a travis PR.

@clienthax
Copy link
Contributor

@danilaml static binary won't care about where its run

@MrSapps
Copy link

MrSapps commented Apr 10, 2017

@danilaml hence my "Erm by travis I mean appveyor in this instance of course ;)" because you confused me by saying travis first ;)

@AlbertAdair
Copy link

Hello, you could create an option to select the user or create a user because in the Game Minecraft RPCS3 asks for access to the UserList for another player to join but as there is no option please you could create that option?

@clienthax
Copy link
Contributor

@AlbertAdair don't spam the issue tracker with irrelevant crap

@scribam scribam mentioned this pull request Sep 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants